Skip to content

Comments

adding missing length attribute to ActionPopMPLS#105

Merged
italovalcy merged 2 commits intomasterfrom
fix/issue_104
Dec 10, 2025
Merged

adding missing length attribute to ActionPopMPLS#105
italovalcy merged 2 commits intomasterfrom
fix/issue_104

Conversation

@italovalcy
Copy link

@italovalcy italovalcy commented Nov 21, 2025

Closes #104

Summary

See updated changelog file and/or add any other summarized helpful information for reviewers

Local Tests

> python3
Python 3.13.2 (main, Feb  4 2025, 14:51:09) [Clang 16.0.0 (clang-1600.0.26.6)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pyof.v0x04.common.action import ActionPopMPLS
>>> a = ActionPopMPLS(ethertype=0)
>>> a.pack()
b'\x00\x14\x00\x08\x00\x00\x00\x00'
>>>

End-to-End Tests

Please refer to the results presented here: #110

The end-to-end tests were executed with all PRs stacked

@italovalcy italovalcy requested a review from a team as a code owner November 21, 2025 19:39
@italovalcy italovalcy self-assigned this Nov 21, 2025
@italovalcy italovalcy mentioned this pull request Dec 3, 2025
Copy link

@Alopalao Alopalao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viniarck viniarck self-requested a review December 6, 2025 17:04
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @italovalcy, thanks for fixing this adjacent issue related to the things you've been working on pyof

@italovalcy italovalcy merged commit 73c7bc5 into master Dec 10, 2025
2 checks passed
@italovalcy italovalcy deleted the fix/issue_104 branch December 10, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action ActionPopMPLS missing length attribute

3 participants