Skip to content

Fix/issue 103 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
italovalcy merged 2 commits into from
Dec 10, 2025
Merged

Fix/issue 103 #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd3b565
fix get_size for instances of ActionHeader itself
italovalcy Nov 21, 2025
1086ff7
update CHANGELOG.rst
italovalcy Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ All notable changes to the `python-openflow` project are documented in this file
Fixed
=====
- Added missing ``ActionPopMPLS.length`` attribute to fix ``PackException`` when packing objects.
- Correct return value for ``get_size()`` when used with ``ActionHeader`` objects directly (useful for TableFeatures Properties).

[2025.1.0] - 2025-04-14
***********************
Expand Down
2 changes: 2 additions & 0 deletions pyof/v0x04/common/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ def get_size(self, value=None):
"""Return the action length including the padding (multiple of 8)."""
if isinstance(value, ActionHeader):
return value.get_size()
if self.__class__ == ActionHeader:
return super().get_size()
if value is None:
current_size = super().get_size()
return ceil(current_size / 8) * 8
Expand Down