Create the ListOfTableId and use it on NextTableProperty#107
Merged
italovalcy merged 1 commit intomasterfrom Dec 10, 2025
Merged
Create the ListOfTableId and use it on NextTableProperty#107italovalcy merged 1 commit intomasterfrom
italovalcy merged 1 commit intomasterfrom
Conversation
viniarck
approved these changes
Nov 23, 2025
Member
viniarck
left a comment
There was a problem hiding this comment.
Well done @italovalcy, great to have ListOfTableId supported and fixed. I'll leave pre-approved, before merging make sure to also include unit tests, the examples you provided as local tests for instance would be great to have as unit tests, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
Summary
See updated changelog file and/or add any other summarized helpful information for reviewers
Local Tests
Without the changes proposed here (i.e., using ListOfInstruction with InstructionGotoTable as suggested in the code):
As you can see above, the length of the NextTablesProperty became much bigger than expected (28 bytes, while it was expected to be 7 bytes). We can also check a packet capture from Noviflow Switch:
Now, after fixing this issue:
Packing and unpacking works as expected:
End-to-End Tests
Please refer to the results presented here: #110
The end-to-end tests were executed with all PRs stacked