feat: make orchestrator/sub-agent sampling temperature configurable - #8
Open
Captain-Tripps wants to merge 1 commit into
Open
Captain-Tripps wants to merge 1 commit into
Captain-Tripps wants to merge 1 commit into
Conversation
_get_default_options() hardcoded temperature=0.0 (fully greedy decoding) with no way to change it short of editing engine code directly. Greedy decoding is a reasonable default for tool-call schema correctness, but it has no randomness to escape a locally-greedy dead end - in practice this can show up as a model announcing an action in prose and then stopping instead of actually emitting the follow-up tool call, since there's nothing to perturb it off whatever single trajectory looked best token-by-token. This is more likely to bite smaller, quantized, or heavily fine-tuned local models than large hosted ones. Adds settings.temperature to config.yaml (default 0.0, matching prior behavior exactly - no behavior change for existing configs that don't set it), documented in config.py's _DEFAULTS and config_template.yaml. Lets users trade a little determinism for better tool-call follow-through on a per-project basis without touching engine code.
Author
|
Love your videos and work here. I'm enjoying this local agent builder! Hoping this feature might help others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_default_options()hardcodedtemperature=0.0(fully greedy decoding) with no way to change it short of editing engine code directly.settings.temperaturetoconfig.yaml(default0.0, matching prior behavior exactly — no behavior change for existing configs that don't set it), documented inconfig.py's_DEFAULTSandconfig_template.yaml. Lets users trade a little determinism for better tool-call follow-through on a per-project basis without touching engine code.Test plan
_get_default_options()readsconfig.cfg["settings"]["temperature"]with a default of0.0.settings.temperatureset behave identically to before (temperature stays0.0).