Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Add select_first() to App and call it after every filter keystroke so newly filtered results are always visible from the top of the viewport - Allow arrow/page/tree-collapse keys to pass through in filter mode so the user can scroll results without leaving the prompt - Refactor FilterInputChar/Backspace to let-else to eliminate the llvm-cov coverage artifact on the now-implicit None arm of if-let - Add unit tests: active_filter, select_first, highlight_matches variants, render_shows_filter_prompt_footer, filter mode key mapping, noop guards, begin_interactive_filter prefill, backspace clears compiled when empty, FilterConfirm/Cancel noop paths, and selection-reset-to-first on char input Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the stale "still mostly monolithic" note and aspirational module list with the current per-module descriptions. Add cli.rs, lib.rs, model.rs, tree.rs, and debug_tui.rs; correct app.rs (state only) and runtime.rs (includes terminal setup); note terminal.rs as a future refactor target. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- BeginInteractiveFilter: apply pre-filled filter to rows immediately instead of waiting for the first keystroke, so the row list matches what the footer shows the moment / is pressed - FilterCancel: call select_first() after restoring rows so the selection resets to the top and doesn't point at a stale index Add behavioral tests for both fixes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.