Enable listing of devices without list-devices subcommand#27
Closed
maresb wants to merge 1 commit into
Closed
Conversation
7578640 to
6801f3a
Compare
Contributor
Author
Contributor
|
I really don't like the idea of |
Contributor
Author
|
Ok, I will fix |
maresb
added a commit
to maresb/labelle
that referenced
this pull request
Apr 28, 2024
maresb
added a commit
to maresb/labelle
that referenced
this pull request
Apr 28, 2024
The change occurred in be39218 in PR labelle-org#22. See labelle-org#27.
5fe2203 to
5b1d401
Compare
Contributor
Author
|
|
5b1d401 to
c59a4c9
Compare
Contributor
Author
|
I think #28 now contains a viable workaround so that this is no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In terms of keeping the CLI simple, I think avoiding subcommands may be a worthy goal. I find it really elegant when
labelle --helpprints a complete summary without needing to explore a tree of help of subcommands.Thus I'm offering this alternative proposal. Introducing a special
--device listcase. It's a bit of a hack, but I think it's a very practical hack: nobody will ever want to filter by the string"list". Also, when the user is trying to figure out what they can filter on, they'll be reading the annotation for--device, and the info is provided there.It seems to me like this sacrifices some mildly ugly code to provide a more focused user interface. Thoughts?