Conversation
…macOS On macOS, Japanese builds failed because user-installed NanumBarunGothic (Korean-only) was loaded before Arial Unicode in CJK_FONT_CANDIDATES, and Thai builds failed because THAI_FONT_CANDIDATES had no macOS paths. Split CJK candidates into language-specific lists so Japanese/Chinese prioritize Arial Unicode (broad CJK coverage) while Korean keeps Nanum for better Hangul rendering. Add macOS Thonburi.ttc to Thai candidates.
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7067 (FR-2745)
Summary
CJK_FONT_CANDIDATESinto language-specific lists:KO_FONT_CANDIDATES(Nanum first for better Hangul) andJA_ZH_FONT_CANDIDATES(Arial Unicode first for Kana/Han coverage)Thonburi.ttcas the first candidate inTHAI_FONT_CANDIDATES(was Linux-only before)loadStampFallbackFontsselection logic to useKO_LANGS/JA_ZH_LANGS/THAI_LANGSsetsRoot Cause
Two issues on macOS:
Japanese:
NanumBarunGothic.ttf(Korean-only, user-installed) appeared beforeArial Unicode.ttfinCJK_FONT_CANDIDATES. The renderer stops at the first successfully loaded font (break), so Japanese builds loaded a Korean-only font that cannot encode Katakana glyphs →WinAnsi cannot encode "セ".Thai:
THAI_FONT_CANDIDATEScontained only Linux paths (/usr/share/fonts/truetype/tlwg/). No macOS Thai font was listed → fell back to Helvetica →WinAnsi cannot encode "ว".Verification
pnpm run pdf:ja—Stamp font loaded: Arial Unicode.ttf— no encoding errorspnpm run pdf:th—Stamp font loaded: Thonburi.ttc— no encoding errors