fix(FR-2775): localize ROLE_ASSIGNMENT and resolve scope name in permission modal#7155
Open
ironAiken2 wants to merge 1 commit intomainfrom
Open
fix(FR-2775): localize ROLE_ASSIGNMENT and resolve scope name in permission modal#7155ironAiken2 wants to merge 1 commit intomainfrom
ironAiken2 wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 9.03% (-0% 🔻) |
1859/20580 |
| 🔴 | Branches | 8.19% (-0.01% 🔻) |
1187/14496 |
| 🔴 | Functions | 5.33% (+0.02% 🔼) |
297/5576 |
| 🔴 | Lines | 8.77% (-0% 🔻) |
1750/19964 |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from b3e4a02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #7154 (FR-2775)
Summary
rbac.types.ROLE_ASSIGNMENTtranslation key to all 21 supported locales (ko: "권한 할당", en: "Role Assignment", etc.) so the Permission Type select no longer falls back to the raw API value.CreatePermissionModal_roleScopeFragmentto fetch the resolvedscope: EntityNodewith inline fragments for DOMAIN / PROJECT / USER / VFOLDER / SESSION / MODEL_DEPLOYMENT / RESOURCE_GROUP / CONTAINER_REGISTRY, mirroring the pattern already used inRolePermissionTab.tsxandRoleScopeTab.tsx."<scopeType> / <resolved name>", falling back to the rawscopeIdonly when the scope object is unresolvable (e.g., STORAGE_HOST and KEYPAIR are not part of theEntityNodeunion yet).valueremains${scopeType}|${scopeId}so backend submissions are unchanged.Test plan
ROLE_ASSIGNMENTentry.ROLE_ASSIGNMENTdisplays as "권한 할당".scripts/verify.shreports=== ALL PASS ===.Notes
EntityNoderesolver they remain as the raw access-key string until backend support lands.