Conversation
…ect onSearch fix Schema changes: - ModelCardV2Filter.domainName/projectId: scalar → StringFilter/UUIDFilter - DeploymentRevisionPresetFilter.runtimeVariantId: UUID → UUIDFilter - useRuntimeParameterSchema: adapt runtimeVariantId filter to UUIDFilter shape BAIGraphQLPropertyFilter: - Add renderInput support for custom filter inputs (e.g. BAIStorageHostSelect) - Add Equals/NotEquals operator i18n keys across all 22 locales BAISelect: - Move onSearch from inside showSearch object to top-level prop - Fixes searchAction never firing (Ant Design v6 ignores onSearch inside showSearch object) AdminModelCardListPage: - Remove flattenGraphQLFilter; use server-side AND/OR/NOT via BAIGraphQLPropertyFilter - Add domainName (string) and storageHost (BAIStorageHostSelect) filter fields ModelStoreListPageV2: - Same server-side filter improvements - Show operator selector for name filter (remove fixedOperator: iContains) - Add domainName and storageHost filter fields
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 81.87% | 429/524 |
| 🟡 | Branches | 70.43% | 362/514 |
| 🟡 | Functions | 76.86% | 93/121 |
| 🟢 | Lines | 83.19% | 391/470 |
Test suite run success
319 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 1fc8ae9
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.11% (-0% 🔻) |
1859/22918 |
| 🔴 | Branches | 7.35% (+0% 🔼) |
1187/16152 |
| 🔴 | Functions | 4.82% (+0.01% 🔼) |
297/6162 |
| 🔴 | Lines | 7.88% (+0% 🔼) |
1750/22201 |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 1fc8ae9
agatha197
changed the title
agatha197
requested review from
ironAiken2,
nowgnuesLee and
yomybaby
and removed request for
nowgnuesLee and
yomybaby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7185 (FR-2786)
Changes
Schema
ModelCardV2Filter.domainName/projectId: scalar →StringFilter/UUIDFilterDeploymentRevisionPresetFilter.runtimeVariantId:UUID→UUIDFilteruseRuntimeParameterSchema: adapt filter call to newUUIDFiltershapeBAIGraphQLPropertyFilter
renderInputprop for custom filter input components (e.g.BAIStorageHostSelect)Equals/NotEqualsoperator i18n keys across all 22 localesBAISelect (bug fix)
onSearchfrom insideshowSearchobject to top-level propsearchActionnever firing — Ant Design v6 ignoresonSearchinsideshowSearch, breaking server-side search inBAIStorageHostSelectAdminModelCardListPage
flattenGraphQLFilter; use server-side AND/OR/NOT viaBAIGraphQLPropertyFilterdomainName(string) andstorageHost(BAIStorageHostSelect) filter fieldsModelStoreListPageV2
fixedOperator: iContainson name filter — show operator selectordomainNameandstorageHostfilter fields