fix(FR-2689): allow longer accelerator names in session launcher selector#7187
Draft
nowgnuesLee wants to merge 1 commit intomainfrom
Draft
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.12% (+0% 🔼) |
1859/22905 |
| 🔴 | Branches | 7.35% | 1187/16156 |
| 🔴 | Functions | 4.83% (+0.02% 🔼) |
297/6154 |
| 🔴 | Lines | 7.89% (+0% 🔼) |
1750/22190 |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from b1f949a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6935 (FR-2689)
Summary
In the session launcher's accelerator-type selector, names longer than
fgpu(e.g., longer device identifiers likecuda.shares) were visually truncated because the innerBAISelectwas pinned to a fixedwidth: 75.Replaced the fixed width with
minWidth: 75, maxWidth: 100on the accelerator-typeBAISelectso the control grows to fit longer labels while keeping the compact baseline for short units likeGPU/fGPU.Test plan
GPU,fGPU) and confirm the selector still renders at the compact 75px width.fgpuand confirm the label is fully visible (no truncation) up to the 100px cap.popupMatchSelectWidth={false}continues to size the popup to its content).