Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates backend.ai-client’s package metadata to improve npm publishability and repo linkage within the monorepo.
Changes:
- Adjusts
repositorymetadata to use a git URL plusdirectory, and adds ahomepageURL. - Updates published package contents (
files) and addspublishConfig.access: public. - Adds a Node.js engine constraint (
>=18) and tweaks export field ordering.
a2c1072 to
d889b7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #7196(FR-2789)
Epic: FR-2792 (backend.ai-client production readiness)
Summary
Tightens
packages/backend.ai-client/package.jsonso the package is safe to publish and predictable to consume. The package is built ESM-only bytsup(format: ['esm']+"type": "module"), so the metadata is shaped to match an ESM-only tarball.Changes
exports— movedtypesbeforeimportper Node ESM resolution rules, norequirebranch (ESM-only).main— kept as./dist/index.jsfor parity with sibling publishable packages (backend.ai-ui,backend.ai-docs-toolkit) that all retainmainalongsidemodule+exportsfor legacy bundlers.engines— added"node": ">=18"(matches the global-fetchbaseline thatclient.tsrelies on).publishConfig.access: public— explicit so a first publish doesn't depend on local registry defaults.repository— switched from a tree URL to a propergit+https://URL withdirectory: "packages/backend.ai-client"so npm's "View Source" link works correctly.homepage— added a tree-anchored URL pointing at the package README.files— addedREADME.mdandLICENSE(sibling PR docs(FR-2788): add LICENSE and README to backend.ai-client #7202 / FR-2788 lands them; pack tolerates missing entries until that lands).Out of scope
Verification
pnpm installfrom repo root — workspace link unchanged.pnpm --filter backend.ai-client run build— ESM 174.99 KB + DTS 65.36 KB.pnpm pack --dry-run(combined with docs(FR-2788): add LICENSE and README to backend.ai-client #7202) — tarball listsdist/,LICENSE,package.json,README.md.import { Client, ClientConfig } from 'backend.ai-client') — both resolve.bash scripts/verify.sh— Relay/Lint/Format pass; TypeScript pre-existing errors inclient.tsexist onorigin/mainand are unrelated to this PR.