fix(BA-3162): Remove agent heartbeat handling observation from audit log#6987
fix(BA-3162): Remove agent heartbeat handling observation from audit log#6987seedspirit wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes HandleHeartbeatAction.spec() from the list of supported actions in the agent processors, effectively excluding agent heartbeat handling from being listed as a supported action. This aligns with the treatment of other internal system actions.
- Removes
HandleHeartbeatActionfrom thesupported_actions()method return list - Maintains the actual heartbeat processing functionality (processor still initialized and functional)
- Follows the existing pattern where internal actions like
mark_agent_exitandmark_agent_runningare also excluded fromsupported_actions()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
HyeockJinKim
left a comment
There was a problem hiding this comment.
Shouldn't we be looking at the part where we're applying action monitors, rather than removing the spec?
HyeockJinKim
left a comment
There was a problem hiding this comment.
The implementation is wrong.
e6d8b8e to
e488c97
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HyeockJinKim
left a comment
There was a problem hiding this comment.
This seems to be the wrong approach.
fregataa
left a comment
There was a problem hiding this comment.
- Using negative phrasing like "SKIP_AUDIT_LOG" in enum names can lead to readability issues, especially when used in conditional statements. But in this case it does not harm readability that much
- All monitors will be skipped during Heartbeat action handling. Is there any monitors that Heartbeat should be done?
|
I believe that the method is wrong, and it can be applied by excluding the monitor at the time of registration, but adding an additional flag field rather increases complexity. This is a problem that needs to be handled differently during registration, not by adding tags or the like and applying them differently after registration. |
9552aac to
4af738e
Compare
1c758eb to
f1b4d27
Compare
fregataa
left a comment
There was a problem hiding this comment.
In my opinion, the action should determine whether it should be excluded by a certain rather than the processor. How do you think? @HyeockJinKim
af2c9c5 to
e8a59b8
Compare
resolves #6966 (BA-3162)
Checklist: (if applicable)
ai.backend.testdocsdirectory