feat: add option to set scaling_groups.use_host_network option from CLI#941
Merged
kyujin-cho merged 4 commits intomainfrom Jan 5, 2023
Merged
feat: add option to set scaling_groups.use_host_network option from CLI#941kyujin-cho merged 4 commits intomainfrom
scaling_groups.use_host_network option from CLI#941kyujin-cho merged 4 commits intomainfrom
Conversation
agatha197
added
type:feature
fregataa
approved these changes
Dec 21, 2022
Member
fregataa
left a comment
fregataa
left a comment
There was a problem hiding this comment.
LGTM.
I tested it and works well
kyujin-cho
changed the title
use_host_network optionscaling_groups.use_host_network option from CLI (#941)
kyujin-cho
changed the title
scaling_groups.use_host_network option from CLI (#941)scaling_groups.use_host_network option from CLI
kyujin-cho
pushed a commit
that referenced
this pull request
Jan 10, 2023
… CLI (#941) Co-authored-by: Joongi Kim <joongi@lablup.com> Backported-from: main Backported-to: 22.09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follows #838
This PR enables CRUD the
use_host_networkoption of scaling group in the client-py.related PR: https://github.com/lablup/backend.ai-control-panel/pull/459