refactor(BA-4910): Use set comprehension for container_ids deduplication#9718
Merged
refactor(BA-4910): Use set comprehension for container_ids deduplication#9718
Conversation
Change container_ids collection from list to set comprehension in collect_container_stat() and collect_process_stat() to automatically deduplicate container IDs and prevent redundant stat collection. Benefits: - Automatic deduplication of container IDs - More efficient (no duplicate processing) - Semantically clearer (expresses intent of unique IDs) - Defensive against edge cases in kernel registry Changes: - src/ai/backend/agent/agent.py:1391: collect_container_stat() - src/ai/backend/agent/agent.py:1403: collect_process_stat() Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the collect_container_stat and collect_process_stat methods to use set comprehensions instead of list construction with a for-loop, deduplicating container IDs and making the intent clearer.
Changes:
- Replace list-based
container_idscollection with set comprehensions in two stat collection methods - Convert the resulting sets back to lists when passing to downstream methods
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ai/backend/agent/agent.py | Refactor container_ids from list+loop to set comprehension in collect_container_stat and collect_process_stat |
| changes/9718.enhance.md | Add changelog entry for the enhancement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jopemachine
previously approved these changes
Mar 6, 2026
jopemachine
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
container_idscollection from list to set comprehension in stat collection methodsTest plan
tests/unit/agent/test_agent.py)Resolves BA-4910