Skip to content

feat(BA-4876): add service/repository layer for permission update#9721

Merged
fregataa merged 2 commits intomainfrom
feat/BA-4876-permission-update-mutation
Mar 6, 2026
Merged

feat(BA-4876): add service/repository layer for permission update#9721
fregataa merged 2 commits intomainfrom
feat/BA-4876-permission-update-mutation

Conversation

@fregataa
Copy link
Member

@fregataa fregataa commented Mar 5, 2026

Summary

  • Add PermissionUpdaterSpec with partial update support for scope_type, scope_id, entity_type, operation fields
  • Add UpdatePermissionAction / UpdatePermissionActionResult action pair
  • Wire service method, action processor, repository, and db_source layers

Test plan

  • pants check/test

Resolves BA-4876 (service layer)

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings March 5, 2026 17:02
@fregataa fregataa self-assigned this Mar 5, 2026
@fregataa fregataa added this to the 26.3 milestone Mar 5, 2026
@fregataa fregataa marked this pull request as draft March 5, 2026 17:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

- PermissionUpdaterSpec in updaters.py (scope_type, scope_id,
  entity_type, operation — role_id excluded)
- UpdatePermissionAction / UpdatePermissionActionResult
- Service method update_permission()
- Repository method with resilience policy
- DB Source method using execute_updater
- Processor wiring in PermissionControllerProcessors

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fregataa fregataa force-pushed the feat/BA-4876-permission-update-mutation branch from 735551e to b881109 Compare March 5, 2026 17:27
@github-actions github-actions bot added size:L 100~500 LoC comp:manager Related to Manager component labels Mar 5, 2026
@fregataa fregataa requested a review from a team March 5, 2026 17:40
fregataa added a commit that referenced this pull request Mar 5, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fregataa fregataa marked this pull request as ready for review March 5, 2026 18:01
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fregataa fregataa force-pushed the feat/BA-4876-permission-update-mutation branch from b6728b3 to 61d4330 Compare March 5, 2026 18:02
@fregataa fregataa changed the title feat(BA-4876): add GraphQL mutation for updating permissions feat(BA-4876): add service/repository layer for permission update Mar 5, 2026
@fregataa fregataa merged commit 25af0bc into main Mar 6, 2026
25 checks passed
@fregataa fregataa deleted the feat/BA-4876-permission-update-mutation branch March 6, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants