Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 50.16% 54.09% +3.92%
==========================================
Files 36 36
Lines 2386 2442 +56
==========================================
+ Hits 1197 1321 +124
+ Misses 1189 1121 -68 ☔ View full report in Codecov by Sentry. |
kyujin-cho
requested changes
Jul 28, 2022
Member
kyujin-cho
left a comment
kyujin-cho
left a comment
There was a problem hiding this comment.
Please add test cases which covers newly created methods.
| parser.add_argument( | ||
| '--repository-path', type=str, | ||
| help='git repository folder path of etcd source code to use. Ff not supplied, ' | ||
| help='git repository folder path of etcd source code to use. If not supplied, ' |
kyujin-cho
requested changes
Jul 29, 2022
kyujin-cho
requested changes
Aug 1, 2022
Member
kyujin-cho
left a comment
kyujin-cho
left a comment
There was a problem hiding this comment.
Just a couple of minor feedbacks!
Member
|
@rapsealk One thing more: Please write down usage examples about new Election API on README.md. |
|
|
|
@rapsealk @kyujin-cho, what is the status of this PR? Do you expect to merge it (after conflicts fixes)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, Etcd's election service methods are added;
This is for further implementation of Etcd-based leader election. I found that vote-based leader election is not a proper method in our case, since we have to ensure that manager cluster runs even the majority of managers are malfunctioning. Therefore, I think it would be better to use Etcd's election API since it provides a
round-robinFIFO-like fashion.References