Open
Conversation
ejeffrey
reviewed
Aug 8, 2017
Contributor
ejeffrey
left a comment
There was a problem hiding this comment.
I think you need to create a labrad/init.py and/or labrad/servers/init.py that does the namespace package stuff. This will also have to be changed in pylabrad.
__path__ = __import__('pkgutil').extend_path(__path__, __name__)
Contributor
Author
|
I added |
Contributor
|
I believe the "real" answer is that whichever package is first in the users PYTHONPATH gets imported first, and needs to have the magic pkgutil snippet to make the later entries get searched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes up the package structure of this repo so that it can be put on the python path without polluting the global package namespace. Mostly file renames, but also had to update some imports for modules that refer to each other. For these imports, I used absolute imports starting with
labrad.servers