Skip to content

refactor(lib): remove duplicated library-search blocks #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboulay merged 1 commit into from
Jun 16, 2026
Merged

refactor(lib): remove duplicated library-search blocks #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/pylsl/lib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,30 +136,6 @@ def find_liblsl_libraries(verbose=False):
if os.path.isfile(path):
yield path

# The active Python env's lib directory (e.g. `conda install -c conda-forge

@sappelhoff sappelhoff Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when reviewing this chunk and wondering why it is entirely removed ... expand the lines upward and you see the exact same block repeated.

# liblsl` lands here). ctypes.util.find_library doesn't search here.
env_libdir = os.path.join(sys.prefix, "lib")
for libprefix in ["", "lib"]:
for debugsuffix in ["", "-debug"]:
path = os.path.join(env_libdir, libprefix + "lsl" + debugsuffix + libsuffix)
if os.path.isfile(path):
yield path

# macOS Frameworks (e.g. installed via `brew install labstreaminglayer/tap/lsl`)
# aren't found by ctypes.util.find_library, but the framework binary is a
# regular dylib that ctypes.CDLL can load directly.
if os_name == "Darwin":
framework_roots = [
"/opt/homebrew/Frameworks", # Apple Silicon homebrew
"/usr/local/Frameworks", # Intel homebrew
os.path.expanduser("~/Library/Frameworks"),
"/Library/Frameworks",
]
for root in framework_roots:
path = os.path.join(root, "lsl.framework", "lsl")
if os.path.isfile(path):
yield path


__dload_msg = (
"You can install the LSL library with conda: `conda install -c conda-forge liblsl`"
Expand Down
Loading