Skip to content

perf(info): avoid duplicate desc().child() lookup in _get_channel_info #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboulay merged 1 commit into from
Jun 16, 2026
Merged

perf(info): avoid duplicate desc().child() lookup in _get_channel_info #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pylsl/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,10 +319,10 @@ def get_channel_units(self) -> typing.Optional[list[typing.Optional[str]]]:

def _get_channel_info(self, name) -> typing.Optional[list[typing.Optional[str]]]:
"""Get the 'channel/name' element in the XML tree."""
if self.desc().child("channels").empty():
channels = self.desc().child("channels")
if channels.empty():
return None
ch_infos = list()
channels = self.desc().child("channels")
ch = channels.child("channel")
while not ch.empty():
ch_info = ch.child(name).first_child().value()
Expand Down
Loading