Extend binary symbol scanning to npm native addons (.node files) - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nodeto the compiled-binary extension set and addextractTarballBinaries()to pull raw binary buffers out of an already-extracted npm tarball, mirroring the existing wheel/zip path.binary-scan.ts/binary-formats.tsfromecosystems/python/toecosystems/shared/, since the ELF/Mach-O/PE parsing was already ecosystem-agnostic and is now consumed by three ecosystems, not one.scanBinary/binaryFindingsDeltainto the npm tarball scan path injavascript/index.tsand the npm-compat path indeno/index.ts, so native addons (better-sqlite3,bcrypt,sharp, etc.) get the same symbol-table/suspicious-string/entropy checks Python wheels already get. JSR packages are untouched — they can't ship native binaries.build/, which is exactly where node-gyp writesbuild/Release/*.node. Binary walking now uses its own minimal skip list (.git,node_modules) instead of the text-scan one, so real-world native addons aren't silently missed.Closes #6
Test plan
pnpm run typecheckpnpm run check(biome lint/format — 0 errors)pnpm test(58 tests passing, including new coverage forextractTarballBinaries/.nodezip entries and thebuild/Releaseskip-dir regression)