fix: MOVED was not being redirected#513
Merged
Merged
Conversation
Owner
|
Thanks, this is a nice fix! merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When using
iredison a redis cluster,MOVEDresponses are not redirected.After some debugging, I noticed
iredisworks when paired withredis==5, but not withredis==7.2:Reason
Prior to redis-py 6,
MOVEDresponses raised aResponseError("MOVED <SLOT> <ADDR>"). When usingredis.ClusterRedis, they raisedMovedError("<SLOT> <ADDR>")instead.MovedErroris a subclass ofResponseError. The important part here is the error message. When raisingMovedError, redis-py removes theMOVEDstring.Starting from redis-py 6, the cluster parser exceptions were moved into the base parser, and so it started raising
MovedError, without theMOVEDstring. This was changed in redis/redis-py#3475. You can also see the changelog for 6.0.0b1, which explicitely lists this as a breaking change:Fix
We keep supporting redis-py <6, but we handle
MovedErrorseparately fromResponseError.