Allow passing a block normally #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to passing a `Proc` as a value, this commit allows us to
pass a first-class block to `Crambda.run_handler`:
Crambda.run_handler do |event, context|
{ foo: "bar", omg: "lol", wtf: 42 }
end
Member
|
This is great! I removed the block signature back in a4dbb0f#diff-04c6e90faac2675aa89e2176d2eec7d8L27 – but I should've kept both. Can you update the documentation so that it mentions both forms? The existing form matches AWS' Ruby runtime, which I think is still worth pointing out. |
|
Is this project still live? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to passing a
Procas a value, this PR allows us to pass a first-class block toCrambda.run_handler:Notice that we don't even need to return a
JSON::Anyexplicitly — we can pass anything that responds toto_json.