options.loadObjects dependent depth (verification advisable)#139
Open
Apehaenger wants to merge 1 commit intolambdabaa:masterfrom
Open
options.loadObjects dependent depth (verification advisable)#139Apehaenger wants to merge 1 commit intolambdabaa:masterfrom
Apehaenger wants to merge 1 commit intolambdabaa:masterfrom
Conversation
I tried to get a quick retrieve of the available address books via
dav.createAccount({accountType : 'carddav', loadCollections: true,
loadObjects: false}), but it wasn't "quick"!
After some debugging I recognized that I also retrieved a list of all
contacts (some hundreds), beside the address books.
I'm not very familiar with WebDAV and also not an RFC extraterrestrial,
but after some reading I interpreted the specs in that way that I only
have to expect the contacts when loadObject = true.
This is what this fix does and now the address book query is quick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to get a quick retrieve of the available address books via
dav.createAccount({accountType : 'carddav', loadCollections: true,
loadObjects: false}), but it wasn't "quick"!
After some debugging I recognized that I also retrieved a list of all
contacts (some hundreds), beside the expected address books.
I'm not very familiar with WebDAV and also not an RFC extraterrestrial,
but after some reading I interpreted the specs in that way that I only
have to expect the contacts when loadObject = true.
This is what this fix does and now the address book query is quick.