Skip to content

Feedback MS1  #6

Description

@Mapirlet

Hello team,

Here is a feedback for the first Milestone:

  1. Good presentation
  • Shows objectives, users, challenges, …
  1. Good understanding of the data
  • Old vs new panel in target variable
  • Can it be due to the location/ orientation ?
  1. Thorough EDA work using the principles covered in the course

  2. GitHub: Very well constructed.

  • README files in CAPS
  • Use of Gitflow principles
  • Right naming conventions (branches)
  1. Clear documentation overall (very digestible overview of your EDA in an md file)

  2. Constructive: Used only 7 days ahead forecast, not 1,2,3,4… Could lead to better performance to do predictions 1 day ahead (if the data is available).

  • Way less accurate

Question: Which model did you use eventually ? The NN or one of the SKLearn models ?

P.S. In the future, let us accept the PR ourselves so that we can comment it directly and not open an issue.

Good luck for the rest of the project,

Matthias Pirlet

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions