Hello team,
Here is a feedback for the first Milestone:
- Good presentation
- Shows objectives, users, challenges, …
- Good understanding of the data
- Old vs new panel in target variable
- Can it be due to the location/ orientation ?
-
Thorough EDA work using the principles covered in the course
-
GitHub: Very well constructed.
- README files in CAPS
- Use of Gitflow principles
- Right naming conventions (branches)
-
Clear documentation overall (very digestible overview of your EDA in an md file)
-
Constructive: Used only 7 days ahead forecast, not 1,2,3,4… Could lead to better performance to do predictions 1 day ahead (if the data is available).
Question: Which model did you use eventually ? The NN or one of the SKLearn models ?
P.S. In the future, let us accept the PR ourselves so that we can comment it directly and not open an issue.
Good luck for the rest of the project,
Matthias Pirlet
Hello team,
Here is a feedback for the first Milestone:
Thorough EDA work using the principles covered in the course
GitHub: Very well constructed.
Clear documentation overall (very digestible overview of your EDA in an md file)
Constructive: Used only 7 days ahead forecast, not 1,2,3,4… Could lead to better performance to do predictions 1 day ahead (if the data is available).
Question: Which model did you use eventually ? The NN or one of the SKLearn models ?
P.S. In the future, let us accept the PR ourselves so that we can comment it directly and not open an issue.
Good luck for the rest of the project,
Matthias Pirlet