Skip to content

PR3 — remove five superseded tally crates (−9,500) - #139

Open
lamemustafa wants to merge 8 commits into
feat/native-outstandingsfrom
refactor/drop-superseded-crates
Open

PR3 — remove five superseded tally crates (−9,500)#139
lamemustafa wants to merge 8 commits into
feat/native-outstandingsfrom
refactor/drop-superseded-crates

Conversation

@lamemustafa

Copy link
Copy Markdown
Owner

Stacked on feat/native-outstandings — review only this PR's own diff.

Local gate green at this level: workspace tests and clippy in both feature configurations, fmt, tools tests, live-read boundary, fixture byte integrity, licence inventory, tsc, production build, and the workflow-consistency gate.

CI is NOT proven: the GitHub-hosted Windows and bundle-smoke jobs have never run, and one read-transport harness test fails deterministically on macOS with an unknown ubuntu outcome.

@lamemustafa
lamemustafa force-pushed the refactor/drop-superseded-crates branch 2 times, most recently from 3e5c785 to 4d5d53d Compare August 14, 2026 07:21
@lamemustafa
lamemustafa marked this pull request as ready for review August 14, 2026 09:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d5d53dbcb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-protocol/tests/native_outstandings.rs
Comment thread src-tauri/src/db/tally_incremental.rs
Comment thread src-tauri/crates/bridge-tally-canonical/Cargo.toml
Comment thread src-tauri/crates/bridge-tally-runtime/Cargo.toml
@lamemustafa
lamemustafa force-pushed the refactor/drop-superseded-crates branch from 4d5d53d to 810e28b Compare August 15, 2026 05:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 810e28baeb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-write/Cargo.toml
@lamemustafa
lamemustafa force-pushed the refactor/drop-superseded-crates branch from 810e28b to 74e4e18 Compare August 16, 2026 06:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74e4e18d6c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/tally/compatibility/compatibility-surface.json Outdated
@lamemustafa
lamemustafa force-pushed the refactor/drop-superseded-crates branch 2 times, most recently from 8954a4b to 3436b82 Compare August 17, 2026 18:16
@lamemustafa
lamemustafa force-pushed the refactor/drop-superseded-crates branch 2 times, most recently from 437fbc1 to f5eda2f Compare August 17, 2026 23:52
Signed-off-by: Tapish Khandelwal <tapishkhandelwal13@gmail.com>
Carry the PR3 removal surface over the F4X BILLREF presentation disclosure. Claims, evidence, and trusted-evidence keys remain byte-identical to the preserved PR3 head.

Compatibility gate: exit 0, unknown_claims=11, evidenced_claims=0. Claims/evidence/trusted identity checks: exit 0.
@lamemustafa
lamemustafa force-pushed the refactor/drop-superseded-crates branch from f5eda2f to 26396f5 Compare August 18, 2026 04:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26396f5a2d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pub scope_sha256: String,
pub plan: SyncPlan,
}
// This module previously also carried a full incremental-sync capability/checkpoint evidence

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Complete the required PR evidence

For this change, which deletes the incremental-sync policy/evidence pipeline and modifies Tally CI, the supplied PR description gives a summary and test claims but no reproducible command, migration-impact note, Tally security-impact note, or completed checklist link. Add these required items before merge so reviewers can assess the fallback behavior and existing-database impact of the removal.

AGENTS.md reference: AGENTS.md:L17-L23

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant