N1.1 — mutation-proof document output guards - #146
Open
lamemustafa wants to merge 6 commits into
Open
Conversation
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 14, 2026 05:30
164081e to
327944e
Compare
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 14, 2026 07:21
327944e to
9658e46
Compare
lamemustafa
marked this pull request as ready for review
August 14, 2026 09:47
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 15, 2026 05:42
9658e46 to
95d740e
Compare
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 16, 2026 06:48
95d740e to
4c8a43d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c8a43d5d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 17, 2026 14:37
4c8a43d to
7190a97
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7190a97f29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 17, 2026 18:16
7190a97 to
06d6f23
Compare
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 17, 2026 21:20
06d6f23 to
b11d72f
Compare
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 17, 2026 23:52
b11d72f to
3876c38
Compare
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 18, 2026 04:21
3876c38 to
5acc37f
Compare
Harden the unprotected client-facing document boundaries demonstrated by the W1 mutation sweep. Add regression coverage that makes PDF invalid-date substitution fail, verifies bulk output bytes rather than file existence alone, and records per-party creation failures in the returned batch manifest. Extract the existing shared report filename predicate unchanged and cover CSV/local-export traversal, hidden-name, and separator rejection; cover single-statement slug portability. Mutation proof: defaulting PDF dates to 01-Jan-2000 passed the prior valid-only test, then failed new invalid_statement_date_fails_instead_of_using_a_default. Replacing bulk write_all(bytes) with write_all(&[]) passed the prior existence-only test, then failed its byte assertion. Silently dropping a file-creation error failed the new manifest test. Returning a default filename and raw party slug each failed their new tests. Existing XLSX/PDF amount/date/text and bulk slug/collision/renderer error mutations were already caught.
Signed-off-by: Tapish Khandelwal <tapishkhandelwal13@gmail.com>
Carry the N1.1 document-boundary surface over the F4X BILLREF presentation disclosure. Claims, evidence, and trusted-evidence keys remain byte-identical to the preserved N1.1 head. Compatibility gate: exit 0, unknown_claims=11, evidenced_claims=0. Claims/evidence/trusted identity checks: exit 0.
lamemustafa
force-pushed
the
tapish-codex/n1-mutation-document-boundaries
branch
from
August 18, 2026 09:10
5acc37f to
aaa855c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
feat/client-grouping— review only this PR's own diff.Local gate green at this level: workspace tests and clippy in both feature configurations, fmt, tools tests, live-read boundary, fixture byte integrity, licence inventory, tsc, production build, and the workflow-consistency gate.
CI is NOT proven: the GitHub-hosted Windows and bundle-smoke jobs have never run, and one read-transport harness test fails deterministically on macOS with an unknown ubuntu outcome.