PHP8.5 Support Added

[cod62627]

Q	A
Documentation	yes/no
Bugfix	yes/no
BC Break	yes/no
New Feature	yes/no
RFC	yes/no
QA	yes/no

Description

[cod62627]

@froschdesign

Two checks are currently failing in the PR. It appears that laminas-db does not yet support PHP 8.4. There’s an open PR discussing PHP 8.4 compatibility — laminas/laminas-db#312
— which hasn’t been merged yet.

Could you please take a look and share your feedback on how we should proceed in this case?

[froschdesign]

@cod62627

… which hasn’t been merged yet.

If you read through the comments on the pull request, you will see that Microsoft is the problem here and that the pull request therefore cannot be merged.

Could you please take a look and share your feedback on how we should proceed in this case?

Do not remove PHP 8.4 from ignore_php_platform_requirements in .laminas-ci.json:

laminas-feed/.laminas-ci.json

Lines 5 to 7 in e595637

	"ignore_php_platform_requirements": {
	"8.4": true
	}

https://github.com/laminas/laminas-feed/pull/107/files#diff-3fb49ad00d3736f1ca8276f568f5d8bbe8c1604f6187ab5ecf921e1012f47c98L5-L7

[cod62627]

@froschdesign

We've completed the work to add PHP 8.5 support, and the PR is now ready for review and merge.
Could you please take a look and share your feedback or any suggestions for improvement?

Thank you for your support!

[sandesh-as]

Hi @froschdesign ,
Just checking in to see if you had a chance to review the PR for PHP 8.5 support.
Please let me know if there’s anything else needed from @cod62627 side.

Thanks again!

[froschdesign]

@cod62627 @sandesh-as
There is no reason to ping anyone, because we know what tasks need to be done. That's why there is a project. And the individual pull requests are reviewed when there is time. There is no rush.
Thanks for your understanding!