test: restore vector and hybrid named-argument coverage - #830
Open
jackylee-ch wants to merge 2 commits into
Open
jackylee-ch wants to merge 2 commits into
jackylee-ch wants to merge 2 commits into
Conversation
testNamedArguments was disabled because it mixed SEARCH assertions with VECTOR_SEARCH/HYBRID_SEARCH ones, and its own TODO asked for this split. Move the SEARCH block into testSearchNamedArguments, which carries the same disabled reason as testSearchTableFunction. Hybrid named arguments (candidates, rrf_k, search_columns, with_row_id) had no other running coverage: testHybridSearchTableFunction only exercises the positional form. No assertion changed.
github-actions
Bot
added
the
chore
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Gate recommendation: approve.
Separating the known-broken SEARCH assertions restores vector and hybrid named-argument coverage without changing production behavior or weakening the assertions. Keeping the SEARCH cases independently disabled also preserves a clear re-enable point for the lance-core fix.
lance-gatekeeper
Bot
added
the
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testNamedArgumentswas disabled because it mixed SEARCH assertions with VECTOR_SEARCH/HYBRID_SEARCH ones, and its own TODO asked for this split. Moves the SEARCH block intotestSearchNamedArguments, which carries the same disabled reason astestSearchTableFunction.Hybrid named arguments (
candidates,rrf_k,search_columns,with_row_id) had no other running coverage:testHybridSearchTableFunctiononly exercises the positional form. No assertion changed.3.5/2.12: 8 tests, 0 failures, 2 skipped. 3.4/2.12: 8 tests, 6 skipped by the version check.