-
Notifications
You must be signed in to change notification settings - Fork 850
fix(scanner): do not lower a negated InList into a take #9097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wjones127
merged 2 commits into
lance-format:main
from
LuciferYang:fix/srid-rowid-not-in
Sep 18, 2026
+71
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guard routes negated
_rowoffsetlists into normal filtering, but_rowoffsetis only materialized byAddRowOffsetExecafterfilter_plan.refine_filter, so this supported variant now errors instead of returning its complement. Materialize_rowoffset(and its required row address) before refinement, or provide an equivalent correct exclusion path, and retain the case below as end-to-end coverage.Reproducer
Adding this sibling to
test_filter_to_take_with_stable_row_idsand runningcargo test -p lance test_filter_to_take_with_stable_row_ids --lib:Expected
[10, 11]; observedInvalidInput: Column _rowoffset does not exist.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The earlier request is withdrawn after recalibration: this guard removes the silent wrong-result path, while other
_rowoffsetpredicates were already unsupported and fail visibly. Full scan-filter support is tracked in #9105, so requiring that feature in this fix was disproportionate.