fix: preserve adaptive IVF probe bounds - #9184
Open
jackye1995 wants to merge 6 commits into
Open
jackye1995 wants to merge 6 commits into
jackye1995 wants to merge 6 commits into
Conversation
github-actions
Bot
added
A-namespace
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
github-actions
Bot
added
A-python
jackye1995
changed the title
lance-gatekeeper
Bot
removed
the
K-approved
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The current head carries the released Namespace 0.13 probe-bound contract through query, explain, and analyze. New bounds override legacy nprobes; minimum- or maximum-only requests preserve adaptive defaults, while legacy nprobes remains exact.
Keeping only the original LSM fix would leave namespace callers unable to express those bounds, so the shared resolver is a focused extension rather than a parallel probe policy.
lance-gatekeeper
Bot
added
the
K-approved
jackye1995
force-pushed
the
jack/adaptive-ivf-lsm-probes
branch
from
September 16, 2026 01:57
d555349 to
66b2c73
Compare
lance-gatekeeper
Bot
removed
the
K-approved
LuQQiu
approved these changes
Sep 16, 2026
jackye1995
force-pushed
the
jack/adaptive-ivf-lsm-probes
branch
from
September 16, 2026 02:10
66b2c73 to
b6720b0
Compare
jackye1995
force-pushed
the
jack/adaptive-ivf-lsm-probes
branch
from
September 16, 2026 05:33
55feabe to
4311e8a
Compare
jackye1995
force-pushed
the
jack/adaptive-ivf-lsm-probes
branch
from
September 16, 2026 05:37
4311e8a to
3a3261b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep vector probe settings unset until explicitly configured so dataset and MemWAL queries inherit adaptive defaults. Preserve
nprobes,minimum_nprobes, andmaximum_nprobesindependently through namespace handling, and definenprobesconsistently as an adaptive maximum across Rust, Python, and Java entry points.