-
Notifications
You must be signed in to change notification settings - Fork 852
feat(knn): expose ANNIvfBatchExec's query, width and inputs #9262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,10 @@ pub mod testing; | |
| pub mod utils; | ||
|
|
||
| pub use filter::LanceFilterExec; | ||
| pub use knn::{ANNIvfPartitionExec, ANNIvfSubIndexExec, KNNVectorDistanceExec}; | ||
| pub use knn::{ | ||
| ANNIvfBatchExec, ANNIvfPartitionExec, ANNIvfSubIndexExec, KNNVectorDistanceExec, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This exposes the new public plan-inspection surface without any repository test that imports
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The requested coverage was added, but it still does not compile; the current projection is this compile failure.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in b0533e1a: the focused public-path test now imports the re-exports and verifies all five accessors; both parameterized cases compile and pass. |
||
| QUERY_INDEX_COL, | ||
| }; | ||
| pub use lance_datafusion::planner::Planner; | ||
| pub use lance_index::scalar::expression::FilterPlan; | ||
| pub use optimizer::get_physical_optimizer; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can there be more than one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, it's just test code