Conversation
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix offset overflow errors for binary and string columns
fix: return actionable errors for binary/string offset overflow
Sep 18, 2026
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
wjones127
reviewed
Sep 18, 2026
Co-authored-by: wjones127 <5488879+wjones127@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
Both decode paths now reject oversized normalized spans before narrowing offsets, while fallible Arrow construction preserves unrelated failures. This keeps normal decoding and the storage format unchanged, and avoids the fixed-length UTF-8 cost reported by the always-64-bit alternative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading or compacting
string/binarydata could still hit Arrow offset-overflow panics when a single batch exceeded 2GiB, leaving users with an opaque failure and no clear mitigation. This change converts those cases into normal Lance errors with guidance to reduce batch size or move tolarge_string/large_binary.Decode overflow handling
NotSupportederrors instead of allowing Arrow internals to panic on oversized batches.User-facing diagnostics
batch_size/LANCE_DEFAULT_BATCH_SIZElarge_string/large_binaryCompaction-adjacent behavior
Representative error shape