feat: route outbound provider requests through an HTTP proxy - #644
Open
Ueslei Lima (uesleilima) wants to merge 1 commit into
Open
feat: route outbound provider requests through an HTTP proxy#644Ueslei Lima (uesleilima) wants to merge 1 commit into
Ueslei Lima (uesleilima) wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 82e1c97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Node's
fetchdoes not honorHTTPS_PROXYon its own, which breaks outbound provider requests behind a corporate HTTP proxy. This PR installs an undiciProxyAgentas the global dispatcher when a proxy URL is configured.Resolution order:
OPENWIKI_PROXY, then the standardHTTPS_PROXY/HTTP_PROXY/ALL_PROXYvariables (both cases). A host without a scheme is treated ashttp://. The proxy URL is persisted inMANAGED_ENV_KEYSand treated as a non-secret diagnostic (URL preview, not a credential).How tested
resolveProxyUrl(preference order, blank fallback, missing scheme).OPENWIKI_PROXYis managed and previewed as a URL.OPENWIKI_PROXYas a URL-typed key.pnpm run format,pnpm run lint,pnpm test(174 files passed, 2336 tests passed).Changeset
Minor changeset in
.changeset/http-proxy-support.md— user-facing feature.Process-lifetime note
Once installed, the undici dispatcher is not swapped if the proxy env changes in the same process (
globalProxyInstalledstays true). Typical CLI usage is one process per invocation, so this is a documented lifecycle constraint rather than a blocker (same observation as rajpratham1's review on #55).Historical context
This was previously bundled with an Anthropic-on-Azure-Foundry provider in #55. This PR isolates HTTP proxy support as a single concern per CONTRIBUTING.md. It does not add a Foundry provider or custom Anthropic headers.