Merge PR #61 and migrate ethylene brownfield capacity - #2
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/RWTH-LTT/optimex/sessions/98d5a08c-042c-46e8-93f3-9271a9c3e3bd Co-authored-by: TimoDiepers <90762029+TimoDiepers@users.noreply.github.com>
This reverts commit d8c0d02. Co-authored-by: TimoDiepers <90762029+TimoDiepers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/RWTH-LTT/optimex/sessions/98d5a08c-042c-46e8-93f3-9271a9c3e3bd Co-authored-by: TimoDiepers <90762029+TimoDiepers@users.noreply.github.com>
…al-argument-foreground-db-name Add configurable foreground database name to LCA processing
…ples-not-code identify flows by tuples not code
…-in-evo-scenario add baseline design in evolution scenario analysis
An installed unit's capacity was treated as available in every year of its operation window, so one unit could deliver its whole lifetime production each year. Installation-dependent flows (construction, end-of-life) were therefore spread over too much output, under-counting them by the number of operating years a vintage was dispatched. Production and operation-dependent flows are now taken at the vintage's current lifecycle stage tau = t - v, and the capacity bound compares unit counts: var_operation[p, v, t] <= var_installation[p, v]. Postprocessing capacity outputs report annual capacity, so they stay comparable with production; get_installation returns unit counts, which are a lifetime quantity. Docstrings, docs and changelog state the convention explicitly.
# Conflicts: # CHANGES.md # src/optimex/lca_processor.py
langeluca
marked this pull request as ready for review
August 1, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CHANGES.mdandlca_processor.pyconflicts, retaining both the upstream identity-based background lookup and the fork's CAPEX/OPEX market-price metadata.Ethylene migration
The modeling assumption remains
0.5e9 kg ethylene/aper Steam Cracker vintage. With a 50-year lifetime and a production exchange totaling 1 kg over the lifetime, one process unit supplies1/50 = 0.02 kg/a. The notebook therefore derives:0.5e9 / 0.02 = 25e9installed process units per vintage25e9 * 0.02 = 0.5e9 kg/aannual capacity per vintageThe brownfield table now reports installed process units separately from annual production capacity.
Validation
25e9 * 0.02 = 0.5e9 kg/aper vintage.The full ethylene notebook was not executed against the local Brightway project in this validation.