Skip to content

refactor(web): optimize list lookup paths #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yevanchen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(web): optimize list lookup paths #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions apps/web/src/routes/files/files-list-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,13 @@ export interface FilesViewModel {
sessionOptions: FilesSessionOption[];
}

function matchesSearch(file: ListedFileEntry, search: string): boolean {
const normalized = search.trim().toLowerCase();

if (!normalized) {
function matchesSearch(file: ListedFileEntry, normalizedSearch: string): boolean {
if (!normalizedSearch) {
return true;
}

return [file.name, file.path, file.id, file.mimeType ?? ""].some((value) =>
value.toLowerCase().includes(normalized),
value.toLowerCase().includes(normalizedSearch),
);
}

Expand Down Expand Up @@ -104,6 +102,7 @@ export function createFilesViewModel(
? selection.sessionId
: "";
const sessionById = new Map(sessions.map((session) => [session.id, session]));
const normalizedSearch = selection.search.trim().toLowerCase();
const visibleFiles = files
.filter((file) => {
if (selection.sessionKind !== "all" && file.sessionKind !== selection.sessionKind) {
Expand All @@ -122,7 +121,7 @@ export function createFilesViewModel(
}
}

return matchesSearch(file, selection.search);
return matchesSearch(file, normalizedSearch);
})
.map((file) =>
Object.assign({}, file, {
Expand Down
Loading