Skip to content

perf(contracts): optimize agent config change comparisons #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yevanchen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(contracts): optimize agent config change comparisons #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions apps/api/tests/agent-versioned-config-plan.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,48 @@ describe("agent versioned config plan", () => {
);
});

test("keeps MCP binding order changes visible", () => {
const plan = planVersionedAgentConfigChange({
agentStatus: "published",
current: createAgentConfigChangeSnapshot({
agent,
environment,
mcpServerIds: ["mcp_linear", "mcp_github"],
skillIds: [],
}),
next: createAgentConfigChangeSnapshot({
agent,
environment,
mcpServerIds: ["mcp_github", "mcp_linear"],
skillIds: [],
}),
});

expect(plan.action).toBe("patch-and-restart");
expect(plan.fieldLabels).toEqual(["MCP Servers"]);
});

test("keeps skill order changes visible", () => {
const plan = planVersionedAgentConfigChange({
agentStatus: "published",
current: createAgentConfigChangeSnapshot({
agent,
environment,
mcpServerIds: [],
skillIds: ["skill_browser", "skill_shell"],
}),
next: createAgentConfigChangeSnapshot({
agent,
environment,
mcpServerIds: [],
skillIds: ["skill_shell", "skill_browser"],
}),
});

expect(plan.action).toBe("patch-and-restart");
expect(plan.fieldLabels).toEqual(["Skills"]);
});

test("classifies advanced provider option edits as patch-and-restart", () => {
const plan = planVersionedAgentConfigChange({
agentStatus: "published",
Expand Down
25 changes: 23 additions & 2 deletions pkgs/contracts/src/agent/agent-config-change-plan.contract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,27 @@ function changed(left: unknown, right: unknown): boolean {
return stableStringify(left) !== stableStringify(right);
}

function orderedStringArraysChanged(left: readonly string[], right: readonly string[]): boolean {
if (left.length !== right.length) {
return true;
}

return left.some((value, index) => value !== right[index]);
}

function skillsChanged(
left: readonly AgentConfigChangeSkill[],
right: readonly AgentConfigChangeSkill[],
): boolean {
if (left.length !== right.length) {
return true;
}

return left.some(
(skill, index) => skill.id !== right[index]?.id || skill.state !== right[index]?.state,
);
}

function pushIfChanged(plans: FieldPlan[], input: FieldPlan & { changed: boolean }): void {
if (!input.changed) {
return;
Expand Down Expand Up @@ -126,7 +147,7 @@ export function classifyAgentConfigChanges(input: {
});
pushIfChanged(fieldPlans, {
action: "patch-and-restart",
changed: changed(input.current.mcpServerIds, input.saved.mcpServerIds),
changed: orderedStringArraysChanged(input.current.mcpServerIds, input.saved.mcpServerIds),
label: "MCP Servers",
rank: 2,
});
Expand Down Expand Up @@ -156,7 +177,7 @@ export function classifyAgentConfigChanges(input: {
});
pushIfChanged(fieldPlans, {
action: "patch-and-restart",
changed: changed(input.current.skills, input.saved.skills),
changed: skillsChanged(input.current.skills, input.saved.skills),
label: "Skills",
rank: 2,
});
Expand Down
Loading