[hvpic-k-devel] hydro sync update node/face loops for hybrid stencils#114
Merged
Conversation
Compare hyb_synchronize_hydro_array in legacy (CPU-only) HVPIC
aarontran
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synchronize_hydro_arrayis updated to match legacy (CPU-only) HVPIC methodhyb_synchronize_hydro_arrayThis PR should fix hydro-dump artifacts at MPI domain boundaries, especially when using QS shape (coming in later PRs).
WARNING: this PR may break downstream analyses, e.g. if any tests expect bitwise agreement in output dumps.
ADJUST_HYDROmacro is commented out to match old (legacy) HVPICADJUST_HYDROmacro loop bounds modified to edit only live cells (N##X+1-->N##X)