[hvpic-k-devel] Misc minor fixes#124
Merged
Merged
Conversation
for half-dt push, only need E field stencils
Non-NGP shape accumulates into ghosts; copy local BC ghosts into adjacent live cells (no reflection implemented yet, to match old CPU Hybrid-VPIC)
Send accumulated current/rho in ghosts to remote edges Using Nigel's GPU-aware MPI interface, but no halo exchange yet
Used in vpic/initialize.cc
* README en-dash -> hyphen, avoid annoying/inscrutable bugs when copy-pasting commands * remove unneeded python dependency * misc cleanup in pcai README
cleanup comments that got split apart by code edits, and fix "void" positioning
To match legacy HVPIC example deck, and also match the enclosed density-perturbation.pdf density-perturbation-with-without-smooth.pdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor quality-of-life code cleanup