fix: Don't shaddow locals when running exec#1
Open
tomdottom wants to merge 1 commit intolanmaster53:masterfrom
Open
fix: Don't shaddow locals when running exec#1tomdottom wants to merge 1 commit intolanmaster53:masterfrom
tomdottom wants to merge 1 commit intolanmaster53:masterfrom
Conversation
When you pass the locals arg to exec you
overwrite/shaddow the locals compiled into the
code object.
This results in NameErrors like:
```
Traceback (most recent call last):
File "test.py", line 12, in <module>
exec(compiled_code, {}, {})
File "<script>", line 8, in <module>
File "<script>", line 6, in bar
NameError: global name 'foo' is not defined
```
From the following simple example:
```
code_string = """
def foo():
return "foo"
def bar():
print foo()
bar()
"""
globals_, locals_ = {}, {}
exec(code_string, globals_, locals_)
```
The code example works when run with:
```
exec(code_string, globals_)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you pass the locals arg to exec you overwrite/shaddow the locals compiled into the code object.
This results in NameErrors like:
From the following simple example:
The code example works when run with: