Add bot startup test to prevent deploying unstartable bots

[Copilot]

Problem

The current test suite validates functional capabilities but doesn't verify that the bot actually starts successfully. This creates a deployment risk where tests pass but the bot fails to start due to:

• Dependency mismatches from npm audit fix or npm outdated
• Missing or malformed environment variables (e.g., Firebase configuration)
• Syntax errors or module loading failures
• Critical service initialization failures

Since the test suite must pass before deployments occur, an unstartable bot can be deployed if the tests don't catch startup failures.

Solution

Added an integration test (spec/bot-startup-spec.js) that spawns the actual bot process and verifies successful startup:

Test Implementation

1. Spawns the real bot process using the mock adapter with all necessary environment variables:

   • FIREBASE_WEB_CONFIG: Minimal Firebase configuration
   • PATH: Includes node_modules/.bin for CoffeeScript
   • NODE_ENV: Set to 'test'
   • HUBOT_HTTPD: Disabled to prevent port conflicts

2. Monitors startup indicators: Watches stderr for successful initialization signals (DeprecationWarning or hubot-heroku-keepalive messages)

3. Detects critical errors: Checks combined stdout/stderr for error patterns:

   • SyntaxError
   • Cannot find module
   • Unable to load
   • is not valid JSON

4. Validates graceful shutdown: Terminates the bot with SIGTERM after confirming successful startup and verifies exit code is 0 or null

5. Implements robust error handling:

   • 20-second safety timeout prevents test hanging
   • Early termination on critical errors
   • Centralized cleanup ensures timers are always cleared
   • Guard prevents done() from being called multiple times

What This Catches

The test will fail (preventing deployment) when:

• Dependencies are misconfigured (e.g., after npm audit fix)
• Required environment variables are missing or malformed
• Syntax errors exist in any loaded module
• Critical services fail to initialize

Testing

• Test suite now includes 20 specs (increased from 19)
• New test completes in ~2.2 seconds
• All existing tests continue to pass
• Linting passes with no issues

Impact

This test provides high confidence that if the test suite passes, the bot will start successfully in production, preventing deployments of unstartable bots.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• tinyurl.com
  • Triggering command: node /home/REDACTED/work/slackbot/slackbot/node_modules/.bin/jasmine (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Create test to make sure the bot actually starts</issue_title>
<issue_description>Describe the bug

The current test suite makes sure functional capabilities are working, but it does not ensure that the bot actually starts up successfully. In cases where there are dependency mismatches — which can easily happen with an npm audit fix or npm outdated and Firebase — the tests run successfully, but the bot does not start.

Expected behavior

A deployment should not occur if the bot will not have a high certainty of starting. Since the test suite is required to pass before deployments can occur, a test that makes sure the bot starts and exits with a 0 status code would prevent deploying an un-startable bot.
</issue_description>

<agent_instructions>Fix this issue</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #56

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[rhamenator]

Looks good to me

[MegTheDev]

Please let me know when you are able to verify these changes locally