feat(checkbox): indeterminate状態を追加#305
Merged
Merged
Conversation
lostfind
force-pushed
the
feature/indeterminate-checkbox
branch
from
400aec4 to
6bb1558
Compare
kawamataryo
approved these changes
Oct 10, 2025
| } | ||
|
|
||
| const iconName = computed(() => (props.indeterminate ? 'minus' : 'check')) | ||
|
|
Contributor
There was a problem hiding this comment.
nits
ネイティブのinputtのindeterminateの属性も更新してあげると、より良いかもと思いました！
watch(
() => props.indeterminate,
(value) => {
if (inputRef.value) inputRef.value.indeterminate = value
},
{ immediate: true }
)https://developer.mozilla.org/ja/docs/Web/API/HTMLInputElement/indeterminate
Member
Author
There was a problem hiding this comment.
提案して頂いたコードは props.indeterminateの初期値がtrueだった場合、DOMへの反映がされない可能性がありましたので、watchの immediate: trueオプションを消してonMountedを追加しました。
Contributor
There was a problem hiding this comment.
なるほどです！！👍
ありがとうございます！！！
lostfind
force-pushed
the
feature/indeterminate-checkbox
branch
from
6bb1558 to
2cff5b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckBoxのindeterminateを追加しました
動作
現在のmodelValueの値にかかわらず、indeterminate状態からクリックする場合、modelValue=trueでチェック状態になります。
indeterminate: true
表示: マイナスアイコン
indeterminate: false
表示: チェックアイコン
indeterminate: true
表示: マイナスアイコン
indeterminate: false
表示: チェックアイコン
indeterminate: false
表示: 未チェック
indeterminate: false
表示: チェックアイコン
indeterminate: false
表示: チェックアイコン
indeterminate: false
表示: 未チェック