Preserve empty objects in MCP JSON config files#793
Open
mwikala wants to merge 1 commit intolaravel:mainfrom
Open
Preserve empty objects in MCP JSON config files#793mwikala wants to merge 1 commit intolaravel:mainfrom
mwikala wants to merge 1 commit intolaravel:mainfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes plain JSON MCP config updates so existing empty objects are preserved when Boost adds a server entry.
Previously, updating an existing
opencode.jsonthat contained an empty object such as"oauth": {}would rewrite it as"oauth": []. OpenCode validates its config schema on startup, so this prevented OpenCode from loading the config after Boost installed its MCP server entry.The change keeps decoded plain JSON objects as objects while still supporting the existing array-based path used for new config creation.
Benefit to End Users
Users with an existing OpenCode MCP config can install Boost without making their OpenCode configuration invalid. Empty object fields such as
oauthremain valid objects, allowing OpenCode to continue loading normally.Backwards Compatibility
This should not break existing behavior because
json_encodesupports both arrays and decoded objects. New file creation still uses the existing array-based config path, and existing plain JSON files now retain their original object/array shapes more accurately.