Skip to content

docs(skills): regenerate lark-mail SKILL.md for user_mailbox allow/blocked senders#702

Open
infeng wants to merge 1 commit intolarksuite:mainfrom
infeng:harness/01kq9v50hxs3qvqg0njny6r5cq
Open

docs(skills): regenerate lark-mail SKILL.md for user_mailbox allow/blocked senders#702
infeng wants to merge 1 commit intolarksuite:mainfrom
infeng:harness/01kq9v50hxs3qvqg0njny6r5cq

Conversation

@infeng
Copy link
Copy Markdown
Collaborator

@infeng infeng commented Apr 28, 2026

Generated by the harness-coding skill.

  • Task ID: 01KQ9V50HXS3QVQG0NJNY6R5CQ
  • Branch: harness/01kq9v50hxs3qvqg0njny6r5cq
  • Target: main

Sprints

ID Title Status Commit
S5 Synthesize transport contract for larksuite/cli passed (contract-only)
S8 Commit codegen output (meta_data.json + SKILL.md) for new resources passed f6ae59e

Source specs

  • /tmp/harness-agent/coding-dev/01KQ9V50HXS3QVQG0NJNY6R5CQ/01KQ9V50HXS3QVQG0NJNY6R5CQ-8/input/tech-design.md

This MR was created autonomously. Quality gates were enforced by the repo's own pre-commit hooks.

Summary by CodeRabbit

Release Notes

  • New Features

    • Added mailbox sender controls: manage allowed and blocked senders with batch create/remove operations and list capabilities.
  • Documentation

    • Enhanced mailbox documentation with improved descriptions of operation details, constraints, and required parameters across mailbox resources.

…ocked senders

Codegen output from cli-registry `make all project=mail` after the registry
sprint added `user_mailbox.allow_senders` and `user_mailbox.blocked_senders`
resources (list / batch_create / batch_remove × 2). The SKILL.md update
adds these two resource sections under `## API Resources` plus 6 rows in
the `## 权限表` section. Other description deltas come from refreshed
upstream meta and ride along with the same regeneration; no hand edits.

`internal/registry/meta_data.json` is gitignored (CI fetches it from the
published registry via scripts/fetch_meta.py), so it is intentionally not
part of this commit.

sprint: S8
@github-actions github-actions Bot added domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact labels Apr 28, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

📝 Walkthrough

Walkthrough

Updates documentation for Lark Mail API with two new mailbox sender-control resources (allow_senders and blocked_senders) featuring batch operations and list capabilities, plus enhanced descriptions across existing mailbox resources and permission scope mappings.

Changes

Cohort / File(s) Summary
New Sender Control API Resources
skills/lark-mail/SKILL.md
Added documentation for user_mailbox.allow_senders and user_mailbox.blocked_senders resources with batch_create, batch_remove, and list methods, including sender type/address-vs-domain behavior, mutual exclusion constraints, limits, and pagination semantics.
Enhanced Documentation & Permission Mappings
skills/lark-mail/SKILL.md
Refined operational semantics for existing mailbox resources (user_mailboxes, drafts, event, folders, labels, mail_contacts, messages, sent_messages, settings, threads); updated permission scope mappings for new sender-control endpoints; documented regression with blank descriptions for user_mailbox.rules.reorder and user_mailbox.rules.update.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • haidaodashushu

Poem

🐰 Hops through the mail with glee,
Allow lists, block lists, let them be!
New sender controls, so neat,
Documentation made complete!
Though some descriptions took a rest,
This mailbox API looks its best! 📬✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete and off-topic. It provides task/sprint metadata and codegen context but lacks the required Summary, Changes, Test Plan, and Related Issues sections specified in the template. Rewrite the description to follow the template: add a Summary section (1-3 sentences on motivation), a Changes section (bulleted list of main changes), a Test Plan section with verification steps, and a Related Issues section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: regenerating SKILL.md documentation for lark-mail with new allow/blocked senders resources.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.80%. Comparing base (7eb0ba3) to head (f6ae59e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files         500      500           
  Lines       43531    43531           
=======================================
  Hits        27773    27773           
  Misses      13317    13317           
  Partials     2441     2441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@f6ae59ef5c75aadaec4a03db25c5ce515e5ec33f

🧩 Skill update

npx skills add infeng/cli#harness/01kq9v50hxs3qvqg0njny6r5cq -y -g

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@skills/lark-mail/SKILL.md`:
- Around line 497-498: The docs currently have empty descriptions for
user_mailbox.rules.reorder and user_mailbox.rules.update in SKILL.md; update the
two entries to include concise descriptions: for user_mailbox.rules.reorder
explain it reorders rule evaluation priority by accepting an ordered list of
rule IDs (or positions) and returns the updated rule sequence, and for
user_mailbox.rules.update describe it updates a specific rule’s properties
(conditions, actions, enabled flag, etc.) given a rule ID and payload and
returns the modified rule; place these summaries in the lines for `reorder` and
`update` respectively so the high-traffic reference shows meaningful
explanations.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 453be56b-284e-4390-9b5c-e77794654d5e

📥 Commits

Reviewing files that changed from the base of the PR and between 6bb988a and f6ae59e.

📒 Files selected for processing (1)
  • skills/lark-mail/SKILL.md

Comment thread skills/lark-mail/SKILL.md
Comment on lines +497 to +498
- `reorder` —
- `update` —
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fill missing method descriptions for rules APIs

Line 497 and Line 498 have empty descriptions for user_mailbox.rules.reorder and user_mailbox.rules.update. This is a docs regression in a high-traffic reference section.

📝 Suggested patch
-  - `reorder` — 
-  - `update` — 
+  - `reorder` — 调整收信规则执行顺序
+  - `update` — 更新指定收信规则的条件或动作配置
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@skills/lark-mail/SKILL.md` around lines 497 - 498, The docs currently have
empty descriptions for user_mailbox.rules.reorder and user_mailbox.rules.update
in SKILL.md; update the two entries to include concise descriptions: for
user_mailbox.rules.reorder explain it reorders rule evaluation priority by
accepting an ordered list of rule IDs (or positions) and returns the updated
rule sequence, and for user_mailbox.rules.update describe it updates a specific
rule’s properties (conditions, actions, enabled flag, etc.) given a rule ID and
payload and returns the modified rule; place these summaries in the lines for
`reorder` and `update` respectively so the high-traffic reference shows
meaningful explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant