Remove legacy code#23
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 60.17% 66.40% +6.23%
==========================================
Files 12 11 -1
Lines 1032 637 -395
Branches 111 51 -60
==========================================
- Hits 621 423 -198
+ Misses 382 189 -193
+ Partials 29 25 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Warning Ignoring CodeRabbit configuration file changes. For security, only the configuration from the base branch is applied for open source repositories. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (22)
📒 Files selected for processing (57)
📝 WalkthroughWalkthroughRemoves the WolframScript MCP server and its tests; bumps version and moves test/dev tooling into a dev dependency group; refactors web-fetch utils and tests; adds large HTTP test cassettes; updates CI, devcontainer, and VS Code settings; adds Claude plan-mode and local settings; several tests and plugin code removed. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.claude/plans/utils_optimizations.md:
- Around line 11-17: The plan to refactor fetch_full_page_content (utils.py) to
use requests will break at runtime because requests is not declared as a project
dependency; before changing the function body, add requests (e.g.
"requests>=2.31.0") to the project manifest (pyproject.toml dependencies) or
update the manifest-checking logic to verify requests is present, then update
fetch_full_page_content to use requests.get and catch requests.exceptions.* and
remove unused imports (gzip, urllib.*, zlib, brotli).
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.claude/rules/general.md:
- Line 4: In the rule string 'At the end of each plan, give me a list of
unresolved questions to answer, if any. Make the questions extremely consise.'
fix the typo by replacing "consise" with "concise" so the sentence reads
"...Make the questions extremely concise."; update the text in the rule (the
exact string shown) to correct the spelling and ensure no other occurrences of
"consise" remain.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/cassettes/test_graph/test_finalizesummary.yaml`:
- Around line 432-495: The vcr_config fixture is missing an explicit record_mode
setting; edit the vcr_config fixture and add the key "record_mode": "none" to
the dict it returns (the configuration dictionary built in the vcr_config
function) so pytest-vcr runs in playback-only mode and prevents new cassette
recordings.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/build.yaml:
- Around line 50-61: The echo lines that append secrets to .env (e.g., the
repeated echo "TAVILY_API_KEY=${{ secrets.TAVILY_API_KEY }}" >> .env pattern)
are vulnerable to shell expansion; replace each echo invocation with a
shell-safe write such as using printf '%s\n' "NAME=${{ secrets.NAME }}" >> .env
or a single-quoted heredoc (e.g., <<'EOF' ... EOF) to ensure secrets containing
", `, $, or \ are not interpreted—update every occurrence for TAVILY_API_KEY,
GEMINI_API_KEY, LOGFIRE_TOKEN, OPENAI_API_KEY, WEATHER_API_KEY, GEO_API_KEY,
BRAVE_API_KEY, SERPER_API_KEY, CODECOV_TOKEN, OPENROUTER_API_KEY,
DEEPINFRA_API_KEY, and TOGETHER_API_KEY accordingly.
In `@pyproject.toml`:
- Around line 13-14: Remove the duplicate dependency entry for
pydantic-ai[examples] in pyproject.toml by deleting the line with
"pydantic-ai[examples]>=0.0.40" so only the intended constraint
"pydantic-ai[examples]>=1.56.0" remains; ensure no other duplicate entries exist
and run your dependency tooling (e.g., poetry lock or pip-compile) to update the
lockfile accordingly.
Comment on lines
+50
to
+61
| echo "TAVILY_API_KEY=${{ secrets.TAVILY_API_KEY }}" >> .env | ||
| echo "GEMINI_API_KEY=${{ secrets.GEMINI_API_KEY }}" >> .env | ||
| echo "LOGFIRE_TOKEN=${{ secrets.LOGFIRE_TOKEN }}" >> .env | ||
| echo "OPENAI_API_KEY=${{ secrets.OPENAI_API_KEY }}" >> .env | ||
| echo "WEATHER_API_KEY=${{ secrets.WEATHER_API_KEY }}" >> .env | ||
| echo "GEO_API_KEY=${{ secrets.GEO_API_KEY }}" >> .env | ||
| echo "BRAVE_API_KEY=${{ secrets.BRAVE_API_KEY }}" >> .env | ||
| echo "SERPER_API_KEY=${{ secrets.SERPER_API_KEY }}" >> .env | ||
| echo "CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }}" >> .env | ||
| echo "OPENROUTER_API_KEY=${{ secrets.OPENROUTER_API_KEY }}" >> .env | ||
| echo "DEEPINFRA_API_KEY=${{ secrets.DEEPINFRA_API_KEY }}" >> .env | ||
| echo "TOGETHER_API_KEY=${{ secrets.TOGETHER_API_KEY }}" >> .env |
There was a problem hiding this comment.
Secret values in double-quoted echo are vulnerable to shell interpretation.
If any secret value contains shell metacharacters (", `, $, \), the echo command will misparse or silently corrupt the .env file. Use a heredoc with single-quoted delimiter or printf '%s\n' to avoid shell expansion of the values.
Safer alternative using printf
- echo "TAVILY_API_KEY=${{ secrets.TAVILY_API_KEY }}" >> .env
- echo "GEMINI_API_KEY=${{ secrets.GEMINI_API_KEY }}" >> .env
+ printf '%s\n' 'TAVILY_API_KEY=${{ secrets.TAVILY_API_KEY }}' >> .env
+ printf '%s\n' 'GEMINI_API_KEY=${{ secrets.GEMINI_API_KEY }}' >> .envApply the same pattern to all remaining lines.
🤖 Prompt for AI Agents
In @.github/workflows/build.yaml around lines 50 - 61, The echo lines that
append secrets to .env (e.g., the repeated echo "TAVILY_API_KEY=${{
secrets.TAVILY_API_KEY }}" >> .env pattern) are vulnerable to shell expansion;
replace each echo invocation with a shell-safe write such as using printf '%s\n'
"NAME=${{ secrets.NAME }}" >> .env or a single-quoted heredoc (e.g., <<'EOF' ...
EOF) to ensure secrets containing ", `, $, or \ are not interpreted—update every
occurrence for TAVILY_API_KEY, GEMINI_API_KEY, LOGFIRE_TOKEN, OPENAI_API_KEY,
WEATHER_API_KEY, GEO_API_KEY, BRAVE_API_KEY, SERPER_API_KEY, CODECOV_TOKEN,
OPENROUTER_API_KEY, DEEPINFRA_API_KEY, and TOGETHER_API_KEY accordingly.
Owner
Author
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request primarily removes legacy code which has been moved to separate repos.
Added
pyproject.tomlChanged
0.1.10build-devcontainerCI job, now cross platformllama3.3by the lighterqwen2.5:14bRemoved
assayspytest plugin (now hosted in separate repo)whlandtar.gzdistributions indist/folderSummary by CodeRabbit
Chores
Refactor
Tests
Documentation