Update vertical_equity_study.py - #357
Open
connorschwartz wants to merge 2 commits into
Open
Conversation
This df_group_to_quantile assignment was deleted in this commit larsiusprime@fcc45b1 seemingly by mistake. The df_group_to_quantile is now not getting assigned, causing failure when this method gets run by the assessment quality notebook.
|
Confirming this from an independent reproduction. Running the assessment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The df_group_to_quantile and self.prd assignments were deleted in this commit fcc45b1 seemingly by mistake. The df_group_to_quantile and prd attribute are now not getting assigned, causing failures in the assessment quality notebook.