Fix clear_cache() malformed .cols/.rows paths - #364
Conversation
clear_cache built the column/row fragment paths as f"{path}.cols{ext}"
(missing the dot before the extension) for the existence check and
f"{path}..cols.{ext}" (double dot) for removal — so the existence check
never matched and the large .cols.parquet / .rows.parquet column-diff
caches were silently left on disk. Use the correct {path}.cols.{ext} /
{path}.rows.{ext} templates. Adds a regression test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thank you for your contribution. I affirm that this contributor has signed the CLA Russell Richie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
|
Independent confirmation: at 7952236 we reproduced the malformed |
clear_cache()built the column/row fragment paths asf"{path}.cols{ext}"(missing the dot before the extension) for the existence check andf"{path}..cols.{ext}"(double dot) for removal — so the existence check never matched and the large.cols.parquet/.rows.parquetcolumn-diff caches were silently left on disk. This uses the correct{path}.cols.{ext}/{path}.rows.{ext}templates.Adds a regression test (
tests/test_clear_cache_paths.py) that creates the full cache artifact set and asserts a clean sweep.