Conversation
cKDTree.query(..., k=k) returns an out-of-range sentinel index when the universe has fewer training parcels than k, raising IndexError at parcel_values[indices]. Add an n_train==0 early return and clamp k = min(k, n_train), mirroring the sales-side guard in _enrich_sup_spatial_lag_for_model_group. Fixes a crash when spatial-lag enrichment runs on sparse universes (Fabrica ENG-3031). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution. I affirm that this contributor has signed the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a guard around
_enrich_universe_spatial_lagso spatial-lag enrichment does not crash when the universe is smaller than the requested neighbor count.Why
Small or heavily filtered universes can have fewer parcels than
k; the nearest-neighbor model should degrade gracefully instead of raising.Validation
tests/test_data.pyfor one-row and zero-training small-universe cases.