Skip to content

Conversation

@medley56
Copy link
Member

Summary

This fixes a bug in the Github release pipeline.

...for the billionth time. Maybe we'll get it right some day.
Copilot AI review requested due to automatic review settings January 21, 2026 22:43
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (975f04a) to head (df9a158).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          48       48           
  Lines        3861     3861           
=======================================
  Hits         3661     3661           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the GitHub release workflow where the PRE_RELEASE_OPTION environment variable was incorrectly handled, potentially causing the gh release create command to fail or behave unexpectedly for non-prerelease versions. The fix refactors the command to use a bash array with conditional logic to only add the --prerelease flag when needed.

Changes:

  • Refactored the GitHub release creation command from a multi-line string to a bash array with conditional logic
  • Added node_modules to .gitignore for prettier pre-commit hook dependencies

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
.gitignore Added node_modules to ignore Node.js dependencies from prettier pre-commit hook
.github/workflows/release.yml Refactored release creation command to use bash array with conditional --prerelease flag addition, fixing bug where PRE_RELEASE_OPTION was incorrectly expanded

@medley56 medley56 merged commit 32ebe69 into main Jan 21, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants