Use diagram-design for ELI5 diagrams - #209
Merged
Merged
Conversation
Owner
Author
Work intentphase: completed
summary: "Make Markover's Diagram Design onboarding repository-owned so a fresh ELI5 thread uses the current Markover design brief without a setup wizard."
touch-points:
- "doc/design/markover-design-brief.md"
- "AGENTS.md"
- ".agents/skills/eli5-html-doc/SKILL.md"
- ".agents/skills/eli5-html-doc/references/optional-surfaces.md"
- ".agents/skills/eli5-html-doc/references/experiment-history.md"
- "test/eli5-guidance.test.ts"
done-when:
- "a fresh checkout contains the approved Markover visual source and complete Diagram Design semantic-role and typography mapping"
- "an ELI5 thread that chooses a diagram treats that repository source as completed onboarding and never pauses for Diagram Design's machine-profile wizard"
- "Diagram Design remains optional and owns diagram grammar while Markover owns visual language, accessibility, containment, and artifact verification"
- "the fallback remains usable when the shared Diagram Design skill is unavailable"
- "skill validation, focused guidance tests, repository checks, and the full test suite pass"
excludes:
- "installing, registering, fetching, updating, copying, or vendoring the shared Diagram Design skill"
- "requiring a home-directory profile, project marker, remote font, or mutation of an installed skill"
- "standalone diagram pages, export flows, or separate diagram artifacts"
blocked-by: []
may-block: []
branch: "t3code/use-diagram-design-for-eli5"
pull-request: 209
head: "f437893" |
Owner
Author
|
Correction from umbrella #205: owner-local onboarding alone was not a portable merge prerequisite. PR #209 now owns the repository-level correction: it will carry the current Markover design brief and instruct ELI5 diagram work to treat that source as completed onboarding, without a home-directory profile or |
lastobelus
marked this pull request as ready for review
August 29, 2026 09:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Boundary
This does not install, register, fetch, update, copy, or vendor diagram-design. It does not require or mutate a home-directory profile, project marker, installed style guide, or remote font. Standalone diagram pages, export flows, and separate diagram artifacts remain out of scope.
Diagram Design may still ask the normal content question needed to select a diagram type or size; the Markover visual onboarding step is what is already completed.
Validation
npm run checknpm test— 905/905 passinggit diff --check