Skip to content

Use diagram-design for ELI5 diagrams - #209

Merged
lastobelus merged 2 commits into
mainfrom
t3code/use-diagram-design-for-eli5
Aug 29, 2026
Merged

Use diagram-design for ELI5 diagrams#209
lastobelus merged 2 commits into
mainfrom
t3code/use-diagram-design-for-eli5

Conversation

@lastobelus

@lastobelus lastobelus commented Aug 29, 2026

Copy link
Copy Markdown
Owner

What changed

  • add the current repository-owned Markover design brief, including the complete Diagram Design semantic-role and typography profile
  • treat that profile as completed onboarding whenever an ELI5 chooses to include a useful diagram, so a fresh thread proceeds without a machine-profile wizard
  • consult the optional shared diagram-design skill for diagram type, density, layout grammar, SVG composition, and connector routing
  • keep Markover branding, accessibility, responsive containment, self-contained output, and verification authoritative
  • fall back quietly to the existing ELI5 diagram guidance when the shared skill is unavailable
  • add a focused regression test for the portable onboarding contract

Boundary

This does not install, register, fetch, update, copy, or vendor diagram-design. It does not require or mutate a home-directory profile, project marker, installed style guide, or remote font. Standalone diagram pages, export flows, and separate diagram artifacts remain out of scope.

Diagram Design may still ask the normal content question needed to select a diagram type or size; the Markover visual onboarding step is what is already completed.

Validation

  • independent fresh-thread acceptance trial: repository profile loads, no onboarding wizard or machine mutation, shared grammar remains optional, fallback remains coherent
  • skill-creator quick validation
  • focused guidance test: 1/1 passing
  • npm run check
  • npm test — 905/905 passing
  • git diff --check

@lastobelus

lastobelus commented Aug 29, 2026

Copy link
Copy Markdown
Owner Author

Work intent

phase: completed
summary: "Make Markover's Diagram Design onboarding repository-owned so a fresh ELI5 thread uses the current Markover design brief without a setup wizard."
touch-points:
  - "doc/design/markover-design-brief.md"
  - "AGENTS.md"
  - ".agents/skills/eli5-html-doc/SKILL.md"
  - ".agents/skills/eli5-html-doc/references/optional-surfaces.md"
  - ".agents/skills/eli5-html-doc/references/experiment-history.md"
  - "test/eli5-guidance.test.ts"
done-when:
  - "a fresh checkout contains the approved Markover visual source and complete Diagram Design semantic-role and typography mapping"
  - "an ELI5 thread that chooses a diagram treats that repository source as completed onboarding and never pauses for Diagram Design's machine-profile wizard"
  - "Diagram Design remains optional and owns diagram grammar while Markover owns visual language, accessibility, containment, and artifact verification"
  - "the fallback remains usable when the shared Diagram Design skill is unavailable"
  - "skill validation, focused guidance tests, repository checks, and the full test suite pass"
excludes:
  - "installing, registering, fetching, updating, copying, or vendoring the shared Diagram Design skill"
  - "requiring a home-directory profile, project marker, remote font, or mutation of an installed skill"
  - "standalone diagram pages, export flows, or separate diagram artifacts"
blocked-by: []
may-block: []
branch: "t3code/use-diagram-design-for-eli5"
pull-request: 209
head: "f437893"

@lastobelus

lastobelus commented Aug 29, 2026

Copy link
Copy Markdown
Owner Author

Correction from umbrella #205: owner-local onboarding alone was not a portable merge prerequisite. PR #209 now owns the repository-level correction: it will carry the current Markover design brief and instruct ELI5 diagram work to treat that source as completed onboarding, without a home-directory profile or .diagram-design marker. The overlapping portable foundation currently on #205 will be reconciled after #209 lands.

@lastobelus
lastobelus marked this pull request as ready for review August 29, 2026 09:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T09:04:27.145917Z f437893 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lastobelus
lastobelus merged commit 2ddb1a6 into main Aug 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant