Stage sanitized public capture state - #210
Merged
lastobelus merged 3 commits intoAug 30, 2026
Merged
Conversation
Owner
Author
Work intentphase: completed
summary: "Merged the verified sanitized Ember Light capture foundation into the umbrella branch."
touch-points:
- "src/instance.ts"
- "scripts/development-bundle.ts"
- "scripts/capture-media.ts"
- "scripts/capture-cli.ts"
- "package.json"
- "doc/launch/issue-16/"
- "test/public-capture.test.ts"
done-when:
- "npm run capture:stage from a clean commit recreates the owned disposable state and launches normal product behavior with Markover production branding, Ember + Light, and an 1180x760 window"
- "the internal capture identity has a distinct bundle key and markover-capture scheme, cannot become canonical-update eligible, and changes no canonical or development behavior"
- "the fixture contains deterministic invented repositories, reviews, statuses, feedback, source proposals, labeled attachments, and workspace selection sufficient for the four stills and demo"
- "all app-data, service, review, source, attachment, settings, workspace, and runtime-receipt paths stay within the disposable capture root, distinct from canonical and development roots"
- "the launcher suppresses protocol registration, consumes no network content, rejects a dirty source tree, and records the exact clean HEAD and fixture revision"
- "focused tests prove repeatability, sanitization, theme, branding, isolation, manifest validity, and the safe reset boundary; npm run ci:local and git diff --check pass"
excludes:
- "capturing or replacing screenshots"
- "recording, encoding, or committing a movie"
- "restyling Pages, README, banner, brand boards, or social cards"
- "changing canonical or development instance behavior"
- "reading canonical reviews, development-instance reviews, real thread metadata, or private source paths"
- "applying live GitHub metadata or publishing announcement content"
blocked-by: []
may-block:
- "public-theme PR #212"
- "current-screenshots child PR"
- "demo-and-launch-assets child PR"
branch: "t3code/capture-foundation"
base: "t3code/refresh-ui-docs-media"
pull-request: 210
head: "eb76b19bba82c3d3ade5a857f66508d6287f2fc4"
completion:
merge-commit: "dbe564de22609b8dd819e25f3fea32686d153db9"
review: "current-head Codex review completed with no findings and zero unresolved threads"
github-ci: "Verify (Node 24) passed"
markover: "zero associated reviews; done succeeded" |
This was referenced Aug 29, 2026
lastobelus
marked this pull request as ready for review
August 30, 2026 22:27
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
lastobelus
added a commit
that referenced
this pull request
Aug 31, 2026
* docs: define public capture contract * feat: stage sanitized public capture state * test: satisfy capture staging quality gates
lastobelus
added a commit
that referenced
this pull request
Aug 31, 2026
* docs: plan Ember Light visual refresh * docs: align visual refresh plan with design brief * Stage sanitized public capture state (#210) * docs: define public capture contract * feat: stage sanitized public capture state * test: satisfy capture staging quality gates * Restyle public surfaces for Ember Light (#212) * style: align public tokens with Ember Light * docs: redraw current public product surfaces * use canonical public app branding * Recapture the current Ember Light product UI (#213) * docs: reserve one strongest product capture * docs: automate current product stills * fix: target the packaged capture renderer * fix: settle captures after hidden toasts * docs: replace product captures with Ember Light * fix: retain capture provenance after restack * Publish the preview demo and launch assets (#214) * chore: start demo and launch assets slice * docs: automate the focused preview demo * docs: show opening the captured review * docs: publish the focused preview demo * docs: finish the focused preview launch assets * test: tighten launch asset assertions * polish public preview typography * fix: retain demo capture provenance after restack * fix: identify Claude Code host examples * fix: use accessible public counter color * fix: reserve Ember orange for non-text accents * fix: carry preview boundary on demo end card * fix: activate unrecorded demo setup directly * docs: regenerate demo with preview boundary * Add Ember Dark to the public site (#217) * add Ember Dark public appearance * match public dark mode to Ember Dark * refine the public site at phone widths * stabilize the responsive footer * keep dark accents readable * keep dark button borders semantic * keep dark dialog and sidebar controls usable * collapse public navigation before controls crowd * Polish focused-preview public copy (#220) * polish public preview copy * align public copy assertions * restore canonical and pane terminology * keep agent and privacy copy contract-accurate * narrow every local-data promise * Stabilize public heading typography (#221) * stabilize the public hero heading * smooth the hero type breakpoint * restore lighter public heading weights * recapture stills from a retained source * recapture demo from a retained source * keep brand assets legible in Ember Dark * keep the mobile disclosure readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Provide one deterministic command that recreates and launches an isolated, public-branded Ember Light Markover state for real screenshot and movie capture without touching canonical reviews.
Stack
t3code/refresh-ui-docs-media)What this adds
markover-capturescheme and bundle ID, and no canonical update eligibility;npm run capture:stage, which resets only its marked disposable root, stages five invented reviews across three real disposable Git repositories, fixes Ember + Light, records the clean source commit, and launches the addressed app;npm run capture:stage -- --prepare-onlyfor non-graphical fixture validation;Boundary
This PR owns only the sanitized fixture, isolated capture launcher, versioned capture manifest/storyboard, and deterministic safety checks. It does not capture or replace screenshots, record a movie, restyle Pages/README, change product behavior for capture, or apply live GitHub metadata.
Evidence
npm run ci:local: lint, typecheck, notices, 915/915 tests, and packaged Electron smoke all passednpm run capture:stage -- --prepare-onlyfrom clean commiteb76b19; receipt confirmed five stable review IDs, Ember Light, and 1180×760ready; its native window reported exactly 1180×760mko_capture01from the running fixture and the publishable projection contained only status, block feedback, attachment IDs/labels, and the source proposalVerify (Node 24)passedgit diff --checkPixel-level visual inspection remains outstanding because this automation process does not have macOS Screen Recording permission. The app launch, window size, fixture service, and handoff path were verified; the later computer-use capture pass still owns visual staging and final media review.
Tracks the visual/media portion of #16. Child of #205.